[WC-2741]: Combobox: Handle multi select selection order #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmanunver
force-pushed
the
wc-2741_combobox_selection_sorting
branch
from
6daed53 to
ad9c47f
Compare
|
make it as option to sort selection items based on caption / value |
rahmanunver
force-pushed
the
wc-2741_combobox_selection_sorting
branch
from
ad9c47f to
db44fa4
Compare
gjulivan
previously approved these changes
Jan 7, 2025
rahmanunver
force-pushed
the
wc-2741_combobox_selection_sorting
branch
from
58012bd to
c31beef
Compare
leonardomendix
previously approved these changes
Jan 21, 2025
leonardomendix
previously approved these changes
Jan 23, 2025
gjulivan
reviewed
Jan 23, 2025
packages/pluggableWidgets/combobox-web/src/helpers/Database/DatabaseMultiSelectionSelector.ts
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Jan 23, 2025
packages/pluggableWidgets/combobox-web/src/helpers/Database/DatabaseMultiSelectionSelector.ts
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Jan 26, 2025
packages/pluggableWidgets/combobox-web/src/helpers/Database/DatabaseMultiSelectionSelector.ts
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Jan 26, 2025
packages/pluggableWidgets/combobox-web/src/helpers/Association/AssociationMultiSelector.ts
Outdated
Show resolved
Hide resolved
gjulivan
force-pushed
the
wc-2741_combobox_selection_sorting
branch
2 times, most recently
from
4dcbfb3 to
529c399
Compare
gjulivan
previously approved these changes
Jan 28, 2025
gjulivan
force-pushed
the
wc-2741_combobox_selection_sorting
branch
8 times, most recently
from
7f8b7f1 to
8ff9329
Compare
gjulivan
force-pushed
the
wc-2741_combobox_selection_sorting
branch
from
ad98168 to
98b7a0b
Compare
leonardomendix
previously approved these changes
Feb 4, 2025
gjulivan
force-pushed
the
wc-2741_combobox_selection_sorting
branch
from
74d6140 to
8625138
Compare
leonardomendix
previously approved these changes
Feb 4, 2025
gjulivan
force-pushed
the
wc-2741_combobox_selection_sorting
branch
from
8625138 to
647a3e6
Compare
gjulivan
approved these changes
Feb 4, 2025
leonardomendix
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
This ensures that the multi-select combobox displays options in the order the user selects them, rather than relying on the index values to determine the display order.